Automatically sort maps to match Soroban environment expectations

stellar / js-stellar-base

The lowest-level stellar helper library. It consists of classes to read, write, hash, and sign Stellar xdr

https://stellar.github.io/js-stellar-base/

Apache License 2.0

106 stars 138 forks source link

Closed Shaptic closed 2 months ago

Shaptic commented 2 months ago

Closes stellar/js-stellar-sdk#996 and stellar/js-stellar-sdk#966.

Note that test changes just involve changing the order of the map fields to be sorted accordingly in the "expected output" portion of the test.

Also, the diff is simpler if you turn whitespace off.

github-actions[bot] commented 2 months ago

Size Change: +1.74 kB (+0.05%)

Total Size: 3.21 MB

Filename	Size	Change
`dist/stellar-base.js`	2.35 MB	+1.42 kB (+0.06%)
`dist/stellar-base.min.js`	855 kB	+318 B (+0.04%)

re1ro commented 2 months ago

Thank you for the expedited solution! 😄