search

stellar / js-stellar-base

The lowest-level stellar helper library. It consists of classes to read, write, hash, and sign Stellar xdr
https://stellar.github.io/js-stellar-base/
Apache License 2.0
108 stars 137 forks source link

Fix the return type of `walkInvocationTree`'s callback to allow void returns as intended #765

Closed Shaptic closed 2 months ago

github-actions[bot] commented 4 months ago

Size Change: +39.5 kB (+1.23%)

Total Size: 3.25 MB

Filename Size Change
dist/stellar-base.js 2.39 MB +29.9 kB (+1.27%)
dist/stellar-base.min.js 867 kB +9.6 kB (+1.12%)

compressed-size-action

sreuland commented 3 months ago

changes look good, can approve, but for consideration, wondering if it's time to introduce ts test to assert these will work from client before releasing, same observation noted on https://github.com/stellar/js-stellar-base/pull/766/files#r1729557085

Shaptic commented 3 months ago

@sreuland good suggestion :pray: generally the type tests don't help much but you can see in 580b2b8 that this actually uncovered the fact that there is in fact a void return value (rather than undefined) which is great :clap: please review again!