Fix bug with signing auth entries in multisig scenarios

stellar / js-stellar-base

The lowest-level stellar helper library. It consists of classes to read, write, hash, and sign Stellar xdr

https://stellar.github.io/js-stellar-base/

Apache License 2.0

108 stars 137 forks source link

Fix bug with signing auth entries in multisig scenarios #772

Closed kalepail closed 2 months ago

kalepail commented 2 months ago

Not every auth entry will be signing for itself, in the case of a multisig account where the master is GAA and the sub is GBB the auth entry will be GAA but we need to sign and check for GBB. We need to check the payload against the key that actually did the signing.

Context: https://discord.com/channels/897514728459468821/1281628550008406078

github-actions[bot] commented 2 months ago

Size Change: +582 B (+0.02%)

Total Size: 3.25 MB

Filename	Size	Change
`dist/stellar-base.js`	2.39 MB	+494 B (+0.02%)
`dist/stellar-base.min.js`	867 kB	+88 B (+0.01%)

_{compressed-size-action}