Open hanseartic opened 2 years ago
Describe the bug Asset properties missing from AccountDebited interface
AccountDebited
What version are you on? 10.0.1
10.0.1
To Reproduce Check effects type definitions. AccountCredited inherits the fields in question from OfferAsset.
AccountCredited
OfferAsset
export interface AccountCredited extends BaseEffectRecord, OfferAsset { type_i: EffectType.account_credited; amount: string; } export interface AccountDebited extends BaseEffectRecord { type_i: EffectType.account_debited; amount: string; }
Expected behavior Handling AccountDebited objects should allow access to the currently not defined fields (i.e. asset_code, asset_issuer, asset_type).
asset_code
asset_issuer
asset_type
Additional context Maybe it would be cleaner to not import those fields from the OfferAsset interface.
Hi, sorry to ask about another topic : how do you import the AccountDebited and other effects into your code ? (from #1098)
Describe the bug Asset properties missing from
AccountDebited
interfaceWhat version are you on?
10.0.1
To Reproduce Check effects type definitions.
AccountCredited
inherits the fields in question fromOfferAsset
.Expected behavior Handling
AccountDebited
objects should allow access to the currently not defined fields (i.e.asset_code
,asset_issuer
,asset_type
).Additional context Maybe it would be cleaner to not import those fields from the
OfferAsset
interface.