search

stellar / js-stellar-sdk

Main Stellar client library for the JavaScript language.
https://stellar.github.io/js-stellar-sdk/
Apache License 2.0
615 stars 296 forks source link

Add yarn fmt changes #964

Closed psheth9 closed 1 week ago

psheth9 commented 1 month ago

Title says it all !!

github-actions[bot] commented 1 month ago

Size Change: 0 B

Total Size: 11.5 MB

ℹ️ View Unchanged | Filename | Size | | :--- | :---: | | `dist/stellar-sdk.js` | 6.37 MB | | `dist/stellar-sdk.min.js` | 5.12 MB |

compressed-size-action

sreuland commented 1 month ago

the changes here look fine, and can approve, but wanted to ask if adding another script target like 'fmt-check' or 'lint' which then runs es-linting or yarn prettier --check to catch these regressions be worthwhile as part of this scope? and then add that new script target as a pre-step in build target so these would get noticed sooner during any ci flow?

psheth9 commented 1 month ago

@sreuland Yes thats a great idea !! I have created the separate issue https://github.com/stellar/js-stellar-sdk/issues/967 for that. would still like to merge this if everything is looking okay.

Shaptic commented 1 month ago

I'll merge this last before releasing so that we don't get screwed by merge conflicts.

Shaptic commented 1 month ago

@sreuland we do this in base here! https://github.com/stellar/js-stellar-base/blob/master/.github/workflows/tests.yml#L42 and can do the same thing here :+1:

Shaptic commented 1 week ago

Closing in favor of #990!