Closed BlaineHeffron closed 3 months ago
@BlaineHeffron I'm too scared to touch the test conflict :sweat_smile:
Addressed @chadoh comments, performed rebase, and then added yarn fmt fixes after the rebase. The main fix applied after the rebase was a dependency cycle involving DEFAULT_TIMEOUT and NULL_ACCOUNT. I moved these to types.ts to fix the issue.
Reverted webauth/utils.ts and addressed the other comments. Should be good to go.
I think you need to merge, @Shaptic!
A number of fixes to remove the warnings and errors across the src/ directory of the project.
I noticed the
src/.eslintrc.js
files was not actually being used when runningyarn fmt
. Sinceyarn fmt
only runs the linter in thesrc
directory anyway, I just merged thesrc/.eslintrc.js
file with the top level.eslintrc.js
file.Then, I added the settings below to be ignored. These were mostly minor docstring formatting complaints or some other trivial things like having spaces in comments.
I then fixed all other issues. The only logic changes are where functions contained for loops, I used iterators instead (e.g forEach, some, filter, etc). There was one case where I added eslint-ignore comments for a double nested for loop that was a bit more complicated so I just decided to leave it be.
Sometimes there were names prefixed with an underscore, in those cases I just removed the underscore.