search

stellar / quickstart

Home of the stellar/quickstart docker image for development and testing
Apache License 2.0
195 stars 206 forks source link

Fix port collision between rpc and horizon in testnet config #497

Closed leighmcculloch closed 1 year ago

leighmcculloch commented 1 year ago

What

Set the port of soroban-rpc in the testnet config to 11726.

Why

In #494 we added soroban-rpc to the testnet config, but accidentally assigned its captive stellar-core the same port that the horizon captive stellar-core uses. This causes one of the two to shut down when starting up.

In the local network config we use 11725 for horizon's captive stellar-core, and 11726 for soroban-rpc's captive stellar-core. This change merely follows suit.

leighmcculloch commented 1 year ago

The reason this bug wasn't identified in tests is because CI tests that horizon captive core works, or soroban-rpc works, and it doesn't test both running at the same time.

We could enable that. I'll do that in a separate PR to evaluate the time cost because the tests in this repo are a balance between running sufficient tests vs keeping test run time and resources reasonable.