Always enable Soroban diagnostic events on local, unless explicitly disabled.
Why
Most of the time when folks are using quickstart in local mode they're developing locally or running quickstart in CI. In these modes diagnostic events are critical for understanding what's happening when things go wrong, and debugging during testing and development.
Much like how we enable other test capabilities in local, we should enable diagnostics because that's the most sensible default for developing in local.
We shouldn't change the default for testnet/pubnet, because diagnostics cause unmetered execution and on testnet/pubnet there's no guarantee other peoples contracts being executed would not cause unreasonable resource consumption.
The addition of the ability to disable on local is so that the Digital Ocean template can turn it off since that is a deployed local instance.
leighmcculloch
commented
1 year ago
What
Always enable Soroban diagnostic events on local, unless explicitly disabled.
Why
Most of the time when folks are using quickstart in local mode they're developing locally or running quickstart in CI. In these modes diagnostic events are critical for understanding what's happening when things go wrong, and debugging during testing and development.
Much like how we enable other test capabilities in local, we should enable diagnostics because that's the most sensible default for developing in local.
We shouldn't change the default for testnet/pubnet, because diagnostics cause unmetered execution and on testnet/pubnet there's no guarantee other peoples contracts being executed would not cause unreasonable resource consumption.
The addition of the ability to disable on local is so that the Digital Ocean template can turn it off since that is a deployed local instance.
Close #474