search

stellar / quickstart

Home of the stellar/quickstart docker image for development and testing
Apache License 2.0
191 stars 205 forks source link

RFC: Enable soroban-rpc by default #566

Closed leighmcculloch closed 7 months ago

leighmcculloch commented 8 months ago

Hi all,

I'm putting out a request for comment for enabling the Soroban RPC by default on the quickstart image.

Today when quickstart starts up core, horizon, and friendbot (on local) come up. To enable the soroban-rpc the --enable-soroban-rpc option has to be used.

The Soroban CLI is headed to become the CLI to use for all things Stellar during development, but it only talks to friendbot and soroban-rpc, so I think it's becoming a bit awkward to keep the soroban-rpc disabled by default. Quickstart is for development and should startup with everything that's needed to dev.

The cost to enabling the soroban-rpc increases the memory usage, so the cost isn't insignificant:

Local: 160mb vs 330mb Testnet: 480mb vs 705mb

So far we haven't had any reports of this memory usage being a problem by anyone using quickstart with rpc. So we don't have any signal that this would actually be a problem.

github-actions[bot] commented 7 months ago

This issue is stale because it has been open for 30 days with no activity. It will be closed in 30 days unless the stale label is removed.

leighmcculloch commented 7 months ago

This has been done and it is now on by default.