Set the default protocol version of local networks explicitly rather than automatically based on stellar-core's support.
Why
Stellar-core is just one application of many that are deployed in the quickstart image and it may support a protocol version that other applications do not.
Applications should be generally upgradeable independent of each other without having to coordinate.
A cost of this change is that we need to remember to update the default protocol version once all the applications are updated, and someone updating their own application may not think about that. We'll need to have a think operationally about how to encourage us to keep it updated.
We could have a job that checks that the version of the protocol is the latest of stellar-core and causes a build to break without that breakage blocking merges, like a warning.
What
Set the default protocol version of local networks explicitly rather than automatically based on stellar-core's support.
Why
Stellar-core is just one application of many that are deployed in the quickstart image and it may support a protocol version that other applications do not.
Applications should be generally upgradeable independent of each other without having to coordinate.
A cost of this change is that we need to remember to update the default protocol version once all the applications are updated, and someone updating their own application may not think about that. We'll need to have a think operationally about how to encourage us to keep it updated.
We could have a job that checks that the version of the protocol is the latest of stellar-core and causes a build to break without that breakage blocking merges, like a warning.