Default to cores max protocol version in local mode when no default specified.
Why
In #594 I removed the automatic default and replaced it with an explicit default because nearing protocol releases we have versions of software being updated in quickstart without coordination, which is good, and having local always startup a network based on core's max supported protocol version meant that in some cases it would start networks that the image as a whole was not ready to run.
When I removed the automatic default I made it so that an explicit default had to be set. That requirement was somewhat unnecessary. For most uses of quickstart simply using what core thinks the version should be is fine, and it's those edge cases where we need it specified.
I'd like to keep it as so so that in other uses of quickstart, like the system-tests, don't need to also coordinate the default version in their default configuration and can rely on quickstart figuring it out for the common case.
What
Default to cores max protocol version in local mode when no default specified.
Why
In #594 I removed the automatic default and replaced it with an explicit default because nearing protocol releases we have versions of software being updated in quickstart without coordination, which is good, and having local always startup a network based on core's max supported protocol version meant that in some cases it would start networks that the image as a whole was not ready to run.
When I removed the automatic default I made it so that an explicit default had to be set. That requirement was somewhat unnecessary. For most uses of quickstart simply using what core thinks the version should be is fine, and it's those edge cases where we need it specified.
I'd like to keep it as so so that in other uses of quickstart, like the system-tests, don't need to also coordinate the default version in their default configuration and can rely on quickstart figuring it out for the common case.
Related: