search

stellar / quickstart

Home of the stellar/quickstart docker image for development and testing
Apache License 2.0
194 stars 205 forks source link

Use latest cpu cost types #645

Open sisuresh opened 10 hours ago

sisuresh commented 10 hours ago

We made some phase 1 cost type changes outside of a protocol boundary that don't get picked up by quickstart, so add them to the upgrade file. This should give testers more accurate instruction counts.

sisuresh commented 9 hours ago

It looks like this breaks the tests. The testout has the log:

!!!!! Unable to upgrade Soroban Config Settings. Stopping all services. !!!!!

Yeah I ended up marking this as a draft. The number of cost types is dependent on protocol, so a change like this doesn't work if all of the images aren't on the same protocol version (latest is still on 21).

leighmcculloch commented 8 hours ago

We could make it so there can be different files for different protocol versions, that probably wouldn't be too difficult. But it also would be fine to wait to merge this until latest reaches 22 which is zero effort.

sisuresh commented 5 hours ago

We could make it so there can be different files for different protocol versions, that probably wouldn't be too difficult. But it also would be fine to wait to merge this until latest reaches 22 which is zero effort.

Yeah I was considering a file for each protocol version available. The issue with waiting until 22 is that we'll just run into the same issue for 23.

leighmcculloch commented 3 hours ago

I was considering a file for each protocol version

Oh. I guess for anyone running their network QuickStart on an old protocol version we'd want to keep files for old protocols too. Because you can specify the protocol version. So different files for each protocol since 20, or 21 at least makes sense 👍