Closed dmkozh closed 5 months ago
@dmkozh Nice! I see that the public API has changed. Did you take into consideration the impact at https://github.com/stellar/soroban-rpc/blob/main/cmd/soroban-rpc/lib/preflight/src/lib.rs and whether it satisfies all the current functionality?
@dmkozh I would like to make sure that all integration tests of soroban-rpc pass after these changes. Could you take a stab at adapting the rpc code?
Another option is to do this in a two-step process, keeping an externally-compatible layer at first.
Did you take into consideration the impact at https://github.com/stellar/soroban-rpc/blob/main/cmd/soroban-rpc/lib/preflight/src/lib.rs and whether it satisfies all the current functionality?
Of course, these changes are meant to be functionally no-op (besides the additional capabilities, like ledger diffs we've discussed before - but there is no need to use them immediately). I'll definitely help with the migration, but this PR has to be finalized first.
What
Refactor soroban-simulation to use the e2e_invoke and also to be more modular/reusable.
e2e_invoke
side.Why
Improving simulation quality, as well as maintainability.
Known limitations
N/A