stellar / rs-soroban-env

Rust environment for Soroban contracts.
Apache License 2.0
59 stars 40 forks source link

Charge for allocation of new `ParsedModule` #1372

Closed jayz22 closed 4 months ago

jayz22 commented 4 months ago

https://github.com/stellar/rs-soroban-env/pull/1359#discussion_r1539882823

graydon commented 4 months ago

Actually I am going to have to revert this -- it doesn't work and isn't necessary. It doesn't work because the existing structure is part of Vm::new and is put in an Rc there with Rc::new but not separately metered, so starting to meter it breaks replay. And it's not necessary since it's actually counted as part of the constant term in the cost of instantiation (or now parsing).