search

stellar / rs-soroban-env

Rust environment for Soroban contracts.
Apache License 2.0
60 stars 39 forks source link

Bump quote and proc-macro2 #1415

Closed salaheldinsoliman closed 2 months ago

salaheldinsoliman commented 2 months ago

What

Bump quote and proc-macro2

Why

There is a crate conflict while updating soroban_sdk crate dependency in Solang: error: failed to select a version forquote. ... required by packageparse-display-derive v0.9.0 ... which satisfies dependencyparse-display-derive = "=0.9.0"of packageparse-display v0.9.0 ... which satisfies dependencyparse-display = "^0.9"of packagesolang v0.3.3 (C:\Users\SalaheldinSoliman\Desktop\solang\solang) versions that meet the requirements^1.0.35` are: 1.0.36, 1.0.35

all possible versions conflict with previously selected packages.

previously selected package quote v1.0.33 ... which satisfies dependency quote = "=1.0.33" of package soroban-builtin-sdk-macros v20.3.0 ... which satisfies dependency soroban-builtin-sdk-macros = "=20.3.0" of package soroban-env-host v20.3.0 ... which satisfies dependency soroban-env-host = "=20.3.0" of package soroban-sdk v20.5.0 ... which satisfies dependency soroban-sdk = "^20.5.0" of package solang v0.3.3 (C:\Users\SalaheldinSoliman\Desktop\solang\solang)

failed to select a version for quote which could resolve this conflict`

Known limitations

N/A

salaheldinsoliman commented 2 months ago

Could you also please update Cargo.lock?

It seems we have to also bump proc-macro2 in order for this to work. Mentioning this #1351 as it is closely related

leighmcculloch commented 2 months ago

Closing because instead of bumping these versions and continue to pin we're going to relax the version requirements in https://github.com/stellar/rs-soroban-env/pull/1351#issuecomment-2097128057.