search

stellar / rs-soroban-sdk

Rust SDK for Soroban contracts.
Apache License 2.0
128 stars 67 forks source link

Remove `--base-version` from cargo semver-checks action #1286

Closed jayz22 closed 5 months ago

jayz22 commented 5 months ago

--base-version was added explicitly in https://github.com/stellar/rs-soroban-sdk/pull/1283/files to get around an issue in semver-checks where it is transitively pulling from a removed sdk version. Below is the full error:

Parsing soroban-token-sdk v21.0.0 (baseline)
error: `cargo metadata` exited with an error:     Updating crates.io index
error: failed to select a version for the requirement `soroban-sdk = "^21.0.0"`
candidate versions found which didn't match: 21.1.0-rc.1, 21.0.1-preview.3, 21.0.1-preview.2, ...
location searched: crates.io index
required by package `soroban-token-sdk v21.0.0`
    ... which satisfies dependency `soroban-token-sdk = "=21.0.0"` of package `rustdoc v0.0.0 (/Users/jay/Projects/rs-soroban-sdk/target/semver-checks/registry-soroban_token_sdk-21_0_0)`
if you are looking for the prerelease package it needs to be specified explicitly
    soroban-sdk = { version = "21.1.0-rc.1" }
perhaps a crate was updated and forgotten to be re-vendored?

Once the new version is released, semver-checks should automatically pull it from cargo as the baseline and we should remove the manual specification.