stellar / rs-stellar-xdr

Rust lib for Stellar XDR.
Apache License 2.0
20 stars 27 forks source link

Run CI for the msrv and latest rust version #341

Closed leighmcculloch closed 10 months ago

leighmcculloch commented 10 months ago

What

Run CI for the msrv and latest rust version. Run clippy and test for msrv, and check and test for latest.

Why

Now that stable releases of the lib have gone out we shouldn't require a new version of Rust in subsequent releases, so we should ensure that the lib continues to build on the msrv. We should also test the latest rust version too since many folks will upgrade to it.

The reason for clippy on msrv and check on latest is because clippy rules change dramatically from one release to the next. While the lib may pass the clippy rules on the msrv, it won't necessarily pass them on latest, because latest in this CI is truly latest available and not the latest we've updated the clippy rules for. We might want to change this in the future, but it's just one way to prevent us from being blocked on PRs because a new Rust was just released with new clippy rules.

Close https://github.com/stellar/rs-soroban-env/issues/1311