Closed sisuresh closed 2 years ago
If you're updating the cargo dependency git hashes you'll also need to update the token contract (and maybe soroban-cli?), otherwise when you try to run ./initialize.sh
, you'll just get 0: "unexpected environment interface version"
Basically, you should be able to run rm -rf .soroban ; make && ./initialize.sh
and not see any errors output. (This would be a great integration test as well)
I initially used i64, because of this bug: https://github.com/stellar/soroban-cli/pull/118, so yeah let's use u64 now. :+1:
@paulbellamy I updated the token contract and tested with rm -rf .soroban ; make && ./initialize.sh
using the latest version of the cli from soroban-cli/main
.
Resolves #9.
Important points about this PR-
withdraw
.deposit
, so should the owner be allowed towithdraw
adeposit
? If not, the owner shouldn't be able to calldeposit
.i64
tou64
.I64
may have been used intentionally, but I'm not sure why so let me know if that should be reverted.advance_ledger
function. This shouldn't affect the tests, but it should still be cleaned up.