build: don't rm target when cleaning

stellar / soroban-example-dapp

End-to-End Example Soroban Dapp

Apache License 2.0

1.03k stars 830 forks source link

build: don't rm target when cleaning #124

Closed chadoh closed 11 months ago

chadoh commented 11 months ago

The clean command was improved in https://github.com/stellar/soroban-example-dapp/pull/122, but it may have been made somewhat too aggressive.

I often symlink my local soroban build into target/bin/soroban. If I forget to remove target from clean, then this quickly gets deleted, which leads to unexpected behavior.

So I've been running reset over and over with target removed from the list of clean targets, and I haven't noticed any problems.

chadoh commented 11 months ago

@tyvdh what do you think?

kalepail commented 11 months ago

Fine with me if the CI build passes

chadoh commented 11 months ago

@tyvdh do you have the ability to merge? I do not.