Open chadoh opened 11 months ago
@tyvdh how's this look to you?
npm ci
breaking in ci but not locally (╯°□°)╯︵ ┻━┻
@tyvdh the build finally passes 😅
Looks like the deps are once again completely absent from package.json
?
@tyvdh yes I was just looking into that; looks like they got removed from main
here https://github.com/stellar/soroban-example-dapp/pull/127
I just added a commit that tries adding them back. Getting npm ci
to actually pass on CI was quite difficult; we'll see if it works 🤞🏼
I just find it hard to believe there isn't a way to handle local packages. How are actual npm packages handling this with CI/CD flows?
Good find; trying it out with the latest commit
What
Roll back https://github.com/stellar/soroban-example-dapp/pull/122, but keep
crowdfund-contract
andabundance-token
inoptionalDependencies
.This also adds a
.gitattributes
to suppresspackage-lock.json
diffs.Why
As I worked with the old version in earnest, iterating on a local copy of the CLI and generating new JS libs over and over, the two-step generate-to-.soroban, then install-to-node_modules wasn't working very well. Probably because the new library wasn't being added until the
postinstall
step, and the dependencies are optional.Generating directly to
node_modules
feels dirty, but it works consistently. At least in this version, compared to the one before #122, you can still see the dependencies listed in theoptionalDependencies
section, so they're not quite as surprising/mysterious.