search

stellar / soroban-example-dapp

End-to-End Example Soroban Dapp
Apache License 2.0
1.05k stars 853 forks source link

Why is this seceret public? #41

Closed willemneal closed 1 year ago

willemneal commented 1 year ago

https://github.com/stellar/soroban-example-dapp/blob/cb63b93b0eb79a797cd497942816379f7a3792ef/shared/constants.tsx#L3

leighmcculloch commented 1 year ago

I believe it is hardcoded for the mint operation that the UI can perform. The admin key is the only key that can be used to mint tokens for the example contract. I think it was included here out of convenience for that. We could have the value supplied through an env variable though, and generated by the user.

cc @paulbellamy

paulbellamy commented 1 year ago

Yes, for production apps this should not be public, but for a demo it is hardcoded here.

@leighmcculloch good suggestion, we should generate and env-var it.

paulbellamy commented 1 year ago

This has been fixed, and now soroban-cli generates a key.