stellar / soroban-example-dapp

End-to-End Example Soroban Dapp
Apache License 2.0
1.05k stars 853 forks source link

feat: add binaryen to package.json to get local wasm-opt binary #43

Closed willemneal closed 1 year ago

willemneal commented 1 year ago

Missing in the README was the dependency of binaryen, this uses the npm release to get a local binary in ./node_modules/.bin

willemneal commented 1 year ago

@leighmcculloch Just removed the unused script, tried again and npm run didn't work.

@paulbellamy Added a note to the readme about needing to run npm install.

paulbellamy commented 1 year ago

@willemneal do we still need this, given https://github.com/stellar/soroban-tools/pull/236?

willemneal commented 1 year ago

@willemneal do we still need this, given stellar/soroban-tools#236?

Yep!