search

stellar / soroban-example-dapp

End-to-End Example Soroban Dapp
Apache License 2.0
1.06k stars 854 forks source link

Make optimized builds optional #47

Closed leighmcculloch closed 1 year ago

leighmcculloch commented 1 year ago

We should remove the optimized build steps from this example's main build process, and have it as an added optional thing. We have kept those steps out of our other examples because they're not really required and they add significant friction to a first build experience.

Related discussion

paulbellamy commented 1 year ago

In soroban-examples, we use make build and make build-optimized. Should probably just do the same here. The balance is with showing best-practices for building real contracts and deployment.

leighmcculloch commented 1 year ago

Turns out we've been doing a thing that meant we were building non-optimized release builds with the stable builds. Fixing that in https://github.com/stellar/soroban-example-dapp/pull/51. This may optimize builds enough that we don't really need to use nightly, at least the tradeoff with using nightly might not be worth it.

tamirms commented 1 year ago

fixed in https://github.com/stellar/soroban-example-dapp/pull/56