stellar / soroban-example-dapp

End-to-End Example Soroban Dapp
Apache License 2.0
1.05k stars 853 forks source link

Followup clean up of builds and makefile #55

Closed leighmcculloch closed 1 year ago

leighmcculloch commented 1 year ago

What

Remove unused features. Use clippy in Makefile. Remove cargo-hack. Remove profiles.

Why

Recently we've made a few changes like only generating a cdylib, and adding clippy to CI. These changes left somethings we can clean up.

If we're only building a cdylib, we can't really offer testutils to other crates, and no crate currently imports the lib and we shouldn't encourage that due to the impact it has on .wasm size. (See #51 for why.) This means we don't need the testutils feature.

We also don't need the export feature, we don't use it anymore.

If we don't have any features we don't really need cargo-hack in a single crate workspace.

Setting profiles is mostly unnecessary. We don't do it in other crates anymore and just let cargo use the defaults for the respective commands.