search

stellar / soroban-example-dapp

End-to-End Example Soroban Dapp
Apache License 2.0
1.06k stars 853 forks source link

fix: rename 'standalone' to 'localnet', get it working #62

Closed chadoh closed 1 year ago

chadoh commented 1 year ago

When running in localnet mode, initialize.sh tries to deploy the optimized Wasm. So it also needs to build-optimized.

Also, the documentation calls it "localnet", not "standalone". It should either be renamed there or here.

esteblock commented 1 year ago

check https://github.com/stellar/soroban-example-dapp/issues/58

paulbellamy commented 1 year ago

I think we use standalone in other tooling around the ecosystem, so let's rename localnet in the docs to match instead.

leighmcculloch commented 1 year ago

Standalone is a specific mode of stellar-core where it is configured to not talk to peers, but I don't think we need to use that term everywhere like we have been, I think localnet is probably better to describe this environment. So @paulbellamy if you think there's a better name I think go for it.

paulbellamy commented 1 year ago

From discussion elsewhere, I agree localnet is a better name. As long as we can be consistent about it, let's go for localnet everywhere then.

esteblock commented 1 year ago

When running in localnet mode, initialize.sh tries to deploy the optimized Wasm. So it also needs to build-optimized.

Also, the documentation calls it "localnet", not "standalone". It should either be renamed there or here.

I thick that there are 2 situations here:

  1. The initialize.sh bug and build-optimized situation was already discussed in https://github.com/stellar/soroban-example-dapp/issues/58 and solved in https://github.com/stellar/soroban-example-dapp/pull/60

  2. The change of 'standalone' to 'localnet' will break too many things. Unless there is an agreement that is early enough to take this step. For me it's clear that it's a local network. And also it's explicit the fact that does not uses several (local) nodes like Avalanche test nets: https://docs.avax.network/quickstart/create-a-local-test-network