add package.json engines and corresponding .nvmrc

stellar / soroban-example-dapp

End-to-End Example Soroban Dapp

Apache License 2.0

1.03k stars 835 forks source link

add package.json engines and corresponding .nvmrc #68

Closed chadoh closed 1 year ago

chadoh commented 1 year ago

I wish the nvmrc were not necessary, but it still is. See https://github.com/nvm-sh/nvm/issues/651

I think nvmrc is the most popular Node version manager, so it probably makes sense to add the .nvmrc. If we want to skip this and go just with the package.json, that's fine too.

paulbellamy commented 1 year ago

I use n, but agree nvm is probably more popular. I don't think adding .nvmrc hurts anything, so 👍