stellar / soroban-example-dapp

End-to-End Example Soroban Dapp
Apache License 2.0
1.03k stars 835 forks source link

Don't use provideWalletChains anymore #82

Closed esteblock closed 1 year ago

esteblock commented 1 year ago

What problem does your feature solve?

Functions and variables defined in wallet/provideWalletChains,tsx are confusing. At the end it does only add a iconBackground parameter to each chain.

What would you like to see?

We could avoid this either:

setIconBacground(chain){
if (chain == chain1) return background1
else if (chain == chain2) return backgorund2
.
.
.
esteblock commented 1 year ago

Solved in https://github.com/stellar/soroban-example-dapp/pull/111