Update example to work with value overhaul

stellar / soroban-example-dapp

End-to-End Example Soroban Dapp

Apache License 2.0

1.08k stars 876 forks source link

Update example to work with value overhaul #92

Closed tsachiherman closed 1 year ago

tsachiherman commented 1 year ago

Epic

stellar/soroban-tools#471

What?

TL;DR: Update example to work with the ScVal overhaul.

This involves work across most of the dApp, but each item should be a fairly straightforward adaptation. A lot of the ScVal stuff is abstracted away, so fixing that abstraction is the bulk of the work:

[ ] Update the underlying js-soroban-client library and use it correctly (related/blocking: stellar/js-soroban-client#60)
[ ] Update the convert.ts helpers to conform to the new format

Shaptic commented 1 year ago

@tsachiherman this is normally handled by the Core team (see the commit history); did you mean for this to apply to https://github.com/stellar/soroban-example-dapp/?

tsachiherman commented 1 year ago

@tsachiherman this is normally handled by the Core team (see the commit history); did you mean for this to apply to https://github.com/stellar/soroban-example-dapp/?

you're correct @Shaptic; I meant it to be soroban-example-dapp. I'll update that.