search

stellar / soroban-example-dapp

End-to-End Example Soroban Dapp
Apache License 2.0
1.08k stars 876 forks source link

Publish a docker image when we do a release of this repo #97

Closed paulbellamy closed 3 months ago

paulbellamy commented 1 year ago

What problem does your feature solve?

Right now, users have to build their own soroban-preview docker image to run stuff locally.

What would you like to see?

We should add a github action which triggers when there is a release, and builds/pushes the docker image to dockerhub.

What alternatives are there?

Spawned from: https://github.com/stellar/soroban-example-dapp/pull/94

esteblock commented 1 year ago

Hello. Just to add some info about the alternative:

I was supporting the following repo: https://github.com/esteblock/soroban-preview-docker/ Docker images then published in https://hub.docker.com/repository/docker/esteblock/soroban-preview/general

In the repo each folder will hold a different Preview Dockerfile. We could also add a github action to publish them

mollykarcher commented 1 year ago

We can use quickstart as a model for how to set this up, but multi-arch will add a lot of complexity here

esteblock commented 1 year ago

We can use quickstart as a model for how to set this up, but multi-arch will add a lot of complexity here

You mean that we can also install soroban-cli in quickstart, and then execute soroban-cli commands inside the quickstart containter? That would be great! Just use one container for all!