search

stellar / soroban-examples

Example Soroban Contracts
Apache License 2.0
65 stars 68 forks source link

Contracts are using WASM from target instead of target-tiny #116

Closed jonjove closed 2 years ago

jonjove commented 2 years ago

What version are you using?

main

What did you do?

make build

What did you expect to see?

https://github.com/stellar/soroban-examples/blob/cad54003976cc8869869933257647b21e60fb337/liquidity_pool/src/token_contract.rs#L16-L19 should use target-tiny.

What did you see instead?

That line uses target instead, which means the liquidity pool contract is huge even when built for target-tiny. Liquidity pool contract is enormous (62k) as a consequence. Liquidity pool router makes the same error (147k). I'm guessing other examples make that error too.

leighmcculloch commented 2 years ago

There is no target-tiny anymore. Everything builds to the target directory. If you build non-optimized, all the imports are non-optimized. If you build optimized, all the imports are optimized.

See https://github.com/stellar/soroban-examples/blob/main/Makefile#L25-L34.

Please reopen if I'm misunderstanding.