search

stellar / soroban-examples

Example Soroban Contracts
Apache License 2.0
65 stars 68 forks source link

Bump sdk and remove BigInt #179

Closed sisuresh closed 1 year ago

sisuresh commented 1 year ago

This PR bumps the sdk to a version that no longer has BigInt.

  1. Note that all BigInt references in the examples have been replaced with i128 (not u128) to match the built-in token contract in rs-soroban-env, but the i128 vs u128 decision is still being discussed here https://discord.com/channels/897514728459468821/1047281257312161832/1047281257312161832.
  2. The liquidity pool contract now includes the num-integer crate so we can take the square root of an i128.
  3. I added some overflow protection, but we need to go through the examples thoroughly and make sure all arithmetic is safe . Issue for this - https://github.com/stellar/soroban-examples/issues/178.