search

stellar / soroban-examples

Example Soroban Contracts
Apache License 2.0
57 stars 60 forks source link

Changes for the next release #277

Closed leighmcculloch closed 11 months ago

leighmcculloch commented 1 year ago

What

All changes for the next release.

Why

To prepare and group changes without merging since developers are reading the docs and looking at the main branch, we don't want to introduce changes for the next release until the next release is out.

cc @sisuresh @dmkozh @tsachiherman

Merging

When it comes time to merge this pull request, it is ideal if an admin can turn off requiring merging via squash, and then the PR is merged with the merge commit strategy.

sreuland commented 1 year ago

@sisuresh , this pr/branch is serving same purpose of latest pre-release as https://github.com/stellar/soroban-examples/releases/tag/testnet was, I think can reference this going forward and retire the former?

@leighmcculloch, will this get bumped to latest sdk from https://github.com/stellar/rs-soroban-sdk/pull/1081 or hold for other? the contracts are used by system-test and working on getting them to pass with latest refs, tools/#928

sisuresh commented 1 year ago

@sisuresh , this pr/branch is serving same purpose of latest pre-release as https://github.com/stellar/soroban-examples/releases/tag/testnet was, I think can reference this going forward and retire the former?

@leighmcculloch, will this get bumped to latest sdk from stellar/rs-soroban-sdk#1081 or hold for other? the contracts are used by system-test and working on getting them to pass with latest refs, tools/#928

Yeah we should retire the tag if possible since that adds an extra step in the process for us.

https://github.com/stellar/soroban-examples/pull/271 updates this PR, but not to https://github.com/stellar/rs-soroban-sdk/pull/1081. I can get to this tomorrow, but @leighmcculloch if you have time to address this today go ahead.