change custom_types contract to be equivalent to the one in soroban-cli

stellar / soroban-examples

Example Soroban Contracts

Apache License 2.0

57 stars 60 forks source link

change custom_types contract to be equivalent to the one in soroban-cli #313

Closed BlaineHeffron closed 2 months ago

BlaineHeffron commented 2 months ago

What

Changing custom_types contract to match the one in stellar-cli.

Why

This allows us to use soroban client init in the js-stellar-sdk instead of using prebuilt wasms. We needed functions to do tests on. I noticed that custom_types in this repo was identical to increment so I figured it was fine to change it.

Close https://github.com/stellar/js-stellar-sdk/issues/980

Known limitations

N/A

chadoh commented 2 months ago

Note that a CI test for the custom_types contract is now failing

BlaineHeffron commented 2 months ago

formatting should be fixed now

willemneal commented 2 months ago

@BlaineHeffron @ElliotFriend @fnando, one Test is failing and I can't seem to have the permissions to re-run it.