stellar / soroban-examples

Example Soroban Contracts
Apache License 2.0
65 stars 68 forks source link

Messages should contain identifier #78

Closed jonjove closed 2 years ago

jonjove commented 2 years ago

What problem does your feature solve?

This came out of a discussion with @leighmcculloch. We want to make message generation extremely uniform, so every argument to a contract function should appear in the message. Currently, we are entirely excluding the Signature type (which includes more than just a signature) from the message.

What would you like to see?

It's not possible to include the signature itself (because you can't produce the signature without the message), so we should convert the Signature to an Identifier and include that Identifier in the message.

What alternatives are there?

It would also be reasonable to include a () in the message.

jonjove commented 2 years ago

Merged in #84.