search

stellar / soroban-rpc

RPC server for Soroban contracts.
11 stars 18 forks source link

Replace `getLedgerEntries()` with a proxy to Core's `/getledgerentry`. #269

Open Shaptic opened 1 month ago

Shaptic commented 1 month ago

Protocol 22: Replacing Endpoints

Epic: https://github.com/stellar/go/issues/5433 References: Platform's issues for Protocol 22: projects/37#31

Stellar Core will have support a high-performance HTTP endpoint for retrieving ledger entries as part of their v22 in stellar/stellar-core#4350. Once stellar/go#5426 is complete, we can completely remove the implementation of getLedgerEntries and its database backing and replace it with a proxy to the Core client.

Acceptance Criteria

The database tables are dropped. The implementation is a proxy to Core. The returned JSON schema stays the same. The performance is still acceptable.

2opremio commented 3 weeks ago

@Shaptic did you start working on this? Otherwise I will take it

Shaptic commented 3 weeks ago

@2opremio this is blocked on Core actually providing this endpoint, but you can take it up if you want to assume the existence of Core's endpoint. I'm working on client support in https://github.com/stellar/go/pull/5428 but again, no real Core yet.

Also note that we will still need entry ingestion + db snapshotting until P23.