stellar / stellar-cli

CLI for Stellar developers
72 stars 70 forks source link

init: ignore `Cargo.*` and `contracts` in `frontend-template` #1578

Open chadoh opened 2 months ago

chadoh commented 2 months ago

While developing frontend templates, it's convenient to test them by adding the stuff that will come with the "backend" part of the contract init template, like contracts and Cargo.toml. Right now, in the new guide I created, I'm advising people not to commit these things, but we could reasonably expect people to do so anyhow, whether on purpose or not. It's just so useful!

I think we should probably just skip importing these files from the frontend template.

But be careful! We need to make sure we don't naïvely just skip importing any path that matches contracts, because it's common for frontend templates to include a src/contracts folder which should be copied over.

Further considerations

ElliotFriend commented 1 month ago
  • Right now we skip importing the .github folder. I think we SHOULD include this one! I would like us to add a test to the official template which ensures that it actually works, and there's no reason to avoid adding this test to projects that use the template. In general, it seems like template consumers would want to end up with the .github folder that the original template had!

I agree! (fwiw)