stellar / stellar-core

Reference implementation for the peer-to-peer agent that manages the Stellar network.
https://www.stellar.org
Other
3.12k stars 970 forks source link

load generator may perform too much work on the main thread #2833

Open MonsieurNicolas opened 3 years ago

MonsieurNicolas commented 3 years ago

Right now it looks like loadgen performs a lot (too much?) of heavy work on the main thread:

As loadgen is scheduled like anything else, I wonder if there is some weird scheduling interaction between the node doing "real work" and performing loadgen related work.

I don't know if it's easy to quantify that effect, or if we should just mitigate all of those issues somehow.

marta-lokhova commented 3 months ago

this came up again during theoretical TPS measurements that @bboston7 did, so should probably be prioritized soon

bboston7 commented 1 month ago

Another acceptable solution (if it works) that came up during the planning meeting is to adjust our tests to generate load from watcher nodes and increase the resources available to those watcher nodes in SSC. This might be a good approach if backgrounding loadgen tasks is painful.