search

stellar / stellar-core

Reference implementation for the peer-to-peer agent that manages the Stellar network.
https://www.stellar.org
Other
3.12k stars 970 forks source link

Remove support for old-style quorum configuration #3007

Open jonjove opened 3 years ago

jonjove commented 3 years ago

New-style quorum configuration was added in https://github.com/stellar/stellar-core/pull/2125, which was released in v11.2.0 on June 26, 2019. The release notes then mentioned that new-style is the preferred method. We should formalize that by removing the old-style.

jacekn commented 3 years ago

It might be good to "deprecate" the old method first to give operators very clear warning this is happening. For example in the next version core could refuse to start unless ALLOW_LEGACY_QUORUM_FORMAT=true is set. That way people who upgrade and are surprised by the change have an easy way to restore old behavior but we also make it clear it's a temporary solution and they have to update configuration before support for the old format is dropped completely.

graydon commented 3 years ago

Note that our local pubnet simulations currently use old-style quorum configuration to express quorum sets measured from the public network, so we'd need a new/different solution for that if we did this.

(I'm no fan of the old-style configuration, but it does map 1:1 with the qsets expressed in the network protocol, which is why we use it this way)