Improve end-to-end simulation testing with BucketListDB

stellar / stellar-core

Reference implementation for the peer-to-peer agent that manages the Stellar network.

https://www.stellar.org

Other

3.12k stars 967 forks source link

Improve end-to-end simulation testing with BucketListDB #4295

Closed SirTyson closed 1 week ago

SirTyson commented 4 months ago

Currently, many of the TransactionFrame and LedgerTxn tests are not compatible with BucketListDB. These tests commit directly to the SQL database, circumventing much of the ledgerClose logic, meaning that entries are not committed to the BucketList. As we deprecate SQL and move towards BucketListDB support only, we should refactor these tests so that they're compatible.

marta-lokhova commented 1 month ago

Given that is kind of an involved task, should we scope this issue more? In the short-term, what we can do is:

[x] fix end-to-end simulations tests, they def need BL DB support - target v22.0.0
[ ] do an audit of the test suite, identify any other tests where coverage is missing (there are more, e.g. upgrades)
[ ] leave tests that don’t need buckets but need in-memory ledger txn as-is, explicitly enable SQL on them such that in tests.cpp we can still enable BL DB.

dmkozh commented 1 week ago

do an audit of the test suite, identify any other tests where coverage is missing

Just FYI, I'm working on https://github.com/stellar/stellar-core/issues/4451, IDK if it falls into the 'test suite audit' bucket, but it seems like a necessary step for disable SQL support completely.

anupsdf commented 1 week ago

Remaining two items tracked here, https://github.com/stellar/stellar-core/issues/4433