[SDP-1379] Properly inject the commit hash when running `make docker-build` - Githubissues

stellar / stellar-disbursement-platform-backend

Stellar Disbursement Platform Backend

Apache License 2.0

37 stars 22 forks source link

[SDP-1379] Properly inject the commit hash when running `make docker-build` #450

Closed marcelosalloum closed 3 weeks ago

marcelosalloum commented 4 weeks ago

What

Properly inject the commit hash when running make docker-build.

Why

Dev instances where not receiving the GIT_COMMIT variable, and it was not being displayed in the /health endpoint.

Checklist

PR Structure

[x] This PR has a reasonably narrow scope (if not, break it down into smaller PRs).
[x] This PR title and description are clear enough for anyone to review it.
[x] This PR does not mix refactoring changes with feature changes (split into two PRs otherwise).

Thoroughness

[x] This PR adds tests for the new functionality or fixes.
[x] This PR contains the link to the Jira ticket it addresses.

Configs and Secrets

[x] No new CONFIG variables are required -OR- the new required ones were added to the helmchart's values.yaml file.
[x] No new CONFIG variables are required -OR- the new required ones were added to the deployments (pr-preview, dev, demo, prd).
[x] No new SECRETS variables are required -OR- the new required ones were mentioned in the helmchart's values.yaml file.
[x] No new SECRETS variables are required -OR- the new required ones were added to the deployments (pr-preview secrets, dev secrets, demo secrets, prd secrets).

Release

[x] This is not a breaking change.
[x] This is ready for production.. If your PR is not ready for production, please consider opening additional complementary PRs using this one as the base. Only merge this into develop or main after it's ready for production!

Deployment

[x] Does the deployment work after merging?

stellar-jenkins commented 4 weeks ago

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr450.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr450.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr450.previews.kube001.services.stellar-ops.com

stellar-jenkins commented 4 weeks ago

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr450.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr450.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr450.previews.kube001.services.stellar-ops.com

stellar-jenkins commented 4 weeks ago

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr450.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr450.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr450.previews.kube001.services.stellar-ops.com

stellar-jenkins commented 4 weeks ago

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr450.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr450.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr450.previews.kube001.services.stellar-ops.com

stellar-jenkins commented 4 weeks ago

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr450.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr450.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr450.previews.kube001.services.stellar-ops.com

stellar-jenkins commented 4 weeks ago

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr450.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr450.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr450.previews.kube001.services.stellar-ops.com

stellar-jenkins commented 4 weeks ago

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr450.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr450.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr450.previews.kube001.services.stellar-ops.com

stellar-jenkins commented 4 weeks ago

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr450.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr450.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr450.previews.kube001.services.stellar-ops.com

stellar-jenkins commented 4 weeks ago

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr450.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr450.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr450.previews.kube001.services.stellar-ops.com

stellar-jenkins commented 3 weeks ago

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr450.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr450.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr450.previews.kube001.services.stellar-ops.com