[SDP-1370] Refactor to improve code reusability and testability

marcelosalloum commented 3 weeks ago

Refactor to improve code reusability and testability by addressing the subtasks raised in PR #452:

[x] Add more unit tests to the POST /disbursements endpoint to ensure all types of registration contact type are persisted
[x] Slightly refactor data/disbursements.go to make the Selector query string into a common constant
[x] Update the custom validator of POST /disburements so it actually does something. Right now it's barely useful and only increases complexity for no reason.
[x] Remove the unused file migrate_1.1.6_to_2.0.0.sh.

Raizen 📈

[x] This PR has a reasonably narrow scope (if not, break it down into smaller PRs).
[x] This PR title and description are clear enough for anyone to review it.
[x] This PR does not mix refactoring changes with feature changes (split into two PRs otherwise).

[x] No new CONFIG variables are required -OR- the new required ones were added to the helmchart's values.yaml file.
[x] No new CONFIG variables are required -OR- the new required ones were added to the deployments (pr-preview, dev, demo, prd).
[x] No new SECRETS variables are required -OR- the new required ones were mentioned in the helmchart's values.yaml file.
[x] No new SECRETS variables are required -OR- the new required ones were added to the deployments (pr-preview secrets, dev secrets, demo secrets, prd secrets).

[x] This is not a breaking change.
[x] This is ready for production.. If your PR is not ready for production, please consider opening additional complementary PRs using this one as the base. Only merge this into develop or main after it's ready for production!