search

stellar / stellar-docs

Documentation for Stellar
https://developers.stellar.org
Apache License 2.0
66 stars 131 forks source link

[WIP] Update RPC OpenRPC spec #1063

Closed aditya1702 closed 2 weeks ago

stellar-jenkins commented 4 weeks ago

Preview is available here:
http://developers-pr1063.previews.kube001.services.stellar-ops.com

2opremio commented 4 weeks ago

Really Nice!

briwylde08 commented 3 weeks ago

Hello! Is this PR still a WIP? Or are we ready to merge? @aditya1702

ElliotFriend commented 2 weeks ago

Before we merge this!

I just had a chance to look at the changes, and it looks like the auto-generated file is the one that got updated. The build process gets re-run, and these changes will be overwritten when the site gets deployed.

The changes should ideally go into the /openrpc/src/stellar-rpc/* source files

ElliotFriend commented 2 weeks ago

@aditya1702 if you want to take a crack at moving the changes into that directory, /openrpc/README.md can help with some guidance and tips.

On the other hand, if you want, I can help migrate the changes into those files. I know it's a tricky setup, and I'd hate for you to have to duplicate the work

aditya1702 commented 2 weeks ago

Hello! Is this PR still a WIP? Or are we ready to merge? @aditya1702

@briwylde08 Actually we do want these changes to go in. However, we had to revert these changes temporarily in rpc for the current release. So it makes more sense to do them in the next one when they actually go through. I will close this PR for now and create a new one then