stellar / stellar-etl

Stellar ETL will enable real-time analytics on the Stellar network
Apache License 2.0
31 stars 12 forks source link

Update bugs related to transaction fees #279

Closed chowbao closed 1 month ago

chowbao commented 1 month ago
PR Checklist ### PR Structure - [ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs). - [ ] This PR avoids mixing refactoring changes with feature changes (split into two PRs otherwise). - [ ] This PR's title starts with the jira ticket associated with the PR. ### Thoroughness - [ ] This PR adds tests for the most critical parts of the new functionality or fixes. - [ ] I've updated the README with the added features, breaking changes, new instructions on how to use the repository. I updated the description of the fuction with the changes that were made. ### Release planning - [ ] I've decided if this PR requires a new major/minor/patch version accordingly to [semver](https://semver.org/), and I've changed the name of the BRANCH to release/_ , feature/_ or patch/\* .

What

There were a couple bugs for transaction fees

Note that for Fee bump transactions feeAccount can be the same as sourceAccount

Slack thread for more context

Why

To correctly report transaction fees

Known limitations

Will need to backfill history_transactions to get correct fees data