PR Checklist
### PR Structure
- [ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
- [ ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
- [ ] This PR's title starts with the jira ticket associated with the PR.
### Thoroughness
- [ ] This PR adds tests for the most critical parts of the new functionality or fixes.
- [ ] I've updated the README with the added features, breaking changes, new instructions on how to use the repository. I updated the description of the fuction with the changes that were made.
### Release planning
- [ ] I've decided if this PR requires a new major/minor/patch version accordingly to
[semver](https://semver.org/), and I've changed the name of the BRANCH to release/_ , feature/_ or patch/\* .
What
There were a couple bugs for transaction fees
Transaction fees were negative due to not using the correct feeAccount for fee bump transactions
The feeCharged amount was fixed in P21 so there needs to be logic handling the correct calculation of feeCharged for <P21 only
Note that for Fee bump transactions feeAccount can be the same as sourceAccount
PR Checklist
### PR Structure - [ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs). - [ ] This PR avoids mixing refactoring changes with feature changes (split into two PRs otherwise). - [ ] This PR's title starts with the jira ticket associated with the PR. ### Thoroughness - [ ] This PR adds tests for the most critical parts of the new functionality or fixes. - [ ] I've updated the README with the added features, breaking changes, new instructions on how to use the repository. I updated the description of the fuction with the changes that were made. ### Release planning - [ ] I've decided if this PR requires a new major/minor/patch version accordingly to [semver](https://semver.org/), and I've changed the name of the BRANCH to release/_ , feature/_ or patch/\* .What
There were a couple bugs for transaction fees
Note that for Fee bump transactions
feeAccount
can be the same assourceAccount
Slack thread for more context
Why
To correctly report transaction fees
Known limitations
Will need to backfill history_transactions to get correct fees data