search

stellar / stellar-protocol

Developer discussion about possible changes to the protocol.
509 stars 301 forks source link

SEP-9 : Add `mobile_number_format` field to Natural Person Fields #1481

Closed CassioMG closed 2 months ago

CassioMG commented 2 months ago

Depending on the integration (e.g the Stellar Disbursement Platform) parts may want to hash the mobile number to increase security during the data sharing between wallets and Anchors.

Ifropc commented 2 months ago

@CassioMG maybe adding a mobile_number format would be a more flexible approach? You can pass the hash in mobile_number field but set "hash" in the mobile_number_format field to indicate the hash format

CassioMG commented 2 months ago

@CassioMG maybe adding a mobile_number format would be a more flexible approach? You can pass the hash in mobile_number field but set "hash" in the mobile_number_format field to indicate the hash format

@Ifropc thanks for the suggestion. What would be the possible values for mobile_number_format in this case?

Ifropc commented 2 months ago

@CassioMG I'd suggest it to be a usual String type with suggested values E164 or E.164 ("Standard" format which we used to see, e.g. +14155552671 see wiki), hash (you should add a small comment about this hash format) and I think that's it for now. If this value is not specified, receiver should assume it's in E164 format

CassioMG commented 2 months ago

@CassioMG I'd suggest it to be a usual String type with suggested values E164 or E.164 ("Standard" format which we used to see, e.g. +14155552671 see wiki), hash (you should add a small comment about this hash format) and I think that's it for now. If this value is not specified, receiver should assume it's in E164 format

@Ifropc I like this idea. I've updated the PR to reflect it. I left a etc... on the field description to add more flexibility to it so sender and receiver could explore this field with different formats other than the suggested ones. Let me know what you think