search

stellar / stellar-protocol

Developer discussion about possible changes to the protocol.
520 stars 304 forks source link

Prettier should output what the diff is required to make it pass #1493

Open leighmcculloch opened 3 months ago

leighmcculloch commented 3 months ago

Prettier currently runs on CI on PRs that change the markdown files, and checks that they are formatted.

However, the output of prettier doesn't say what's wrong and what needs fixing:

Screenshot 2024-06-14 at 10 34 55 am

It would be helpful for folks without prettier installed if the diff was outputted so that they could copy-paste and apply that diff locally.

Alternatively, the CI could even apply the diff and push it to the PR.

cc @Ifropc

Ifropc commented 3 months ago

I tried applying the diff and pushing to PR, but it didn't work because other jobs were not triggered by that commit (and we require all jobs to pass before merge), but I'll look into printing the diff

github-actions[bot] commented 1 month ago

This issue is stale because it has been open for 30 days with no activity. It will be closed in 30 days unless the stale label is removed.