search

stellar / supercluster

Stellar-core integration test automation tool
Other
9 stars 16 forks source link

Increase logging interval of job monitor to 10 minutes #198

Closed sisuresh closed 3 months ago

sisuresh commented 3 months ago

There's no need to log this often.

jayz22 commented 3 months ago

This is probably fine to land. But if we are going to change this, we should probably reduce frequency of mission querying the job-monitor, since it'll just be querying stale data for 10 mins. Alternative, we should probably make the querying frequency for the redis queues, where mission control logic relies on, separate from querying frequency for the workers (where the status is just for info). This way the mission still gets frequently up-to-date status about the jobs (number of completion, in-progress, etc.) whereas the worker info is purely informational.

sisuresh commented 3 months ago

This is probably fine to land. But if we are going to change this, we should probably reduce frequency of mission querying the job-monitor, since it'll just be querying stale data for 10 mins. Alternative, we should probably make the querying frequency for the redis queues, where mission control logic relies on, separate from querying frequency for the workers (where the status is just for info). This way the mission still gets frequently up-to-date status about the jobs (number of completion, in-progress, etc.) whereas the worker info is purely informational.

Good point. Updated the interval.