Closed chadoh closed 1 year ago
@sreuland can you review please? (I am not currently allowed to use GitHub's "request review" feature)
@chadoh , would you mind running this version of system test locally against your latest compiled soroban-tools cli
to confirm tests work as expected? can be done locally in 2 steps(full doc here for reference):
// this runs docker image with soroban services,
// can run in one terminal, or run as daemonized,
// it'll print `Tests can now begin` once it's initialized
$ docker run --platform linux/amd64 --rm -it --name e2e_test -p "8000:8000" stellar/system-test:1.0.1 --CoreDebianVersion "19.6.1-1158.c0ad35aa1.focal~soroban" --HorizonDebianVersion "2.22.0~soroban-323" --SorobanRPCDebianVersion 0.4.0-10 --RunTargetStackOnly true
// when the docker prints it's ready for tests, run this from system-test folder in another terminal,
// will execute the tests using `soroban` cli from your path
// uses services on 8000 port from docker
system-test$ SorobanExamplesGitHash="main" \
SorobanExamplesRepoURL="https://github.com/stellar/soroban-examples.git" \
TargetNetworkPassPhrase="Standalone Network ; February 2017" \
TargetNetworkSecretKey="SC5O7VZUXDJ6JBDSZ74DSERXL7W3Y5LTOAMRF7RQRL3TAGAPS7LUVG3L" \
TargetNetworkPublicKey="GBZXN7PIRZGNMHGA7MUUUF4GWPY5AYPV6LY4UV2GL6VJGIQRXFDNMADI" \
TargetNetworkRPCURL="http://localhost:8000/soroban/rpc" \
VerboseOutput=true \
go test -v ./features/dapp_develop/...
Thanks for teaching me how to do that, @sreuland! It helped me find a bug, which I've now fixed. My tests pass locally.
dynamic CLI args under development at https://github.com/stellar/soroban-tools/pull/307