search

stellare-modular / vcv-link

Ableton Link module for VCV Rack
GNU General Public License v3.0
66 stars 15 forks source link

Compile fail on Linux (Ubuntu 16.04) #3

Closed cschol closed 5 years ago

cschol commented 6 years ago

Compiling the feature/v06_compatibility branch:

g++ -DLINK_PLATFORM_LINUX=1 -Wsuggest-override -std=c++11 -DSLUG=StellareModular-Link -DVERSION=0.6.0dev -Imodules/link/include -Imodules/link/modules/asio-standalone/asio/include -Ilink-wrapper -fPIC -I../../../Rack/include -I../../../Rack/dep/include -DSLUG=StellareModular-Link -DVERSION=0.6.0dev -MMD -MP -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -c -o build/link-wrapper/link-wrapper.cpp.o link-wrapper/link-wrapper.cpp
In file included from modules/link/include/ableton/discovery/InterfaceScanner.hpp:22:0,
                 from modules/link/include/ableton/discovery/PeerGateways.hpp:22,
                 from modules/link/include/ableton/discovery/Service.hpp:22,
                 from modules/link/include/ableton/link/Controller.hpp:22,
                 from modules/link/include/ableton/platforms/Config.hpp:22,
                 from modules/link/include/ableton/Link.hpp:25,
                 from link-wrapper/link-wrapper.cpp:23:
modules/link/include/ableton/platforms/asio/AsioWrapper.hpp:53:20: fatal error: asio.hpp: No such file or directory
compilation terminated.
../../../Rack/compile.mk:57: recipe for target 'build/link-wrapper/link-wrapper.cpp.o' failed
make: *** [build/link-wrapper/link-wrapper.cpp.o] Error 1

I assume this means libasio-dev is required for building. The plugin should provide this dependency in a make dep step, like Rack does for all of its dependencies. Do you think that is possible?

sanderbaan commented 6 years ago

@petertools ? can you take care of this?

petertools commented 6 years ago

@cschol can you build our master or develop branch with the same machine/configuration? I checked and nothing really changed in the dependencies of Link and asio-standalone. Are you sure you checked out the submodules recursively?

sanderbaan commented 6 years ago

I think they have a build system now for the plugin manager which builds the plugins automatically for us...thats why it probably needs to be in the makefile ?

cschol commented 6 years ago

@petertools @sanderbaan Right, we are trying to make the plugin build process more self contained. Requiring to install a certain library is not optimal (and won't work) for that process. Andrew provided an example of how to include a dependency library (in this case libsamplerate) into a plugin in Fundamental. It would be great if you could provide all dependencies that way. Not sure if it is possible with your dependencies.

stellare-modular commented 5 years ago

Starting with version 0.6.2 Stellare Modular Link is available through VCV Rack's Plugin Manager. We provided binaries as if we were to release a closed source plugin, nevertheless the link to this repo is included in the manifest.