search

stellarwp / schema

A library for simplifying the creation, update, and field modification of custom tables within WordPress.
GNU General Public License v2.0
26 stars 2 forks source link

Move files to src/ #25

Closed szepeviktor closed 1 year ago

szepeviktor commented 1 year ago

src/Schema/ 👉🏻 src/ After #20

"src/Schema/" is PSR-0!

borkweb commented 1 year ago

The /src/Schema/ pattern is purposeful so that we have /src/functions/, /src/views/, /src/admin-views/, /src/deprecated/, etc as sibling directories to the PHP class directories.

A worthy suggestion, but one that we won't be adopting as we like to have a separation between those concerns listed above while keeping all of the source code under a single tree. (i.e. we are not interested in /admin-views over /src/admin-views/.

szepeviktor commented 1 year ago

All right. I let you store non PHP classes in src/.

... although it violates the 1 thing in 1 box principle.

borkweb commented 1 year ago

Haha, thank you for the permission :D

Thats what the Schema directory is for - it accomplishes the 1 thing in 1 box principle at a lower depth.

szepeviktor commented 1 year ago

It is Thursday. I'm not able control my emotions when I see something other than a PHP class in a PSR-4 directory. Tomorrow I may change!