Create new layer is broken

[stellasia]

Clicking on "Create new layer" reloads the page without actually updating the map. On top of that, the available node labels and properties are not shown anymore.

/cc @jodom

[okjodom]

Ack.

---

From: Estelle Scifo notifications@github.com Sent: Sunday, 6 September 2020, 06:21 To: stellasia/neomap Cc: Jodom Konuko; Mention Subject: [stellasia/neomap] Create new layer is broken (#77)

Clicking on "Create new layer" reloads the page without actually updating the map. On top of that, the available node labels and properties are not shown anymore.

/cc @jodomhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjodom&data=02%7C01%7CJodom.Konuko%40microsoft.com%7Ce97d5992c864434cb68508d85267c33b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637349952892756855&sdata=wB5F4%2FWsmE21lxfNer%2FH%2FhoLucqg3kGB3UGVD1W4gqU%3D&reserved=0

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fstellasia%2Fneomap%2Fissues%2F77&data=02%7C01%7CJodom.Konuko%40microsoft.com%7Ce97d5992c864434cb68508d85267c33b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637349952892756855&sdata=UAbiT3l7w471IKC%2B33TEWt%2FIXTpFQVeRPiQSfL4mw28%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACVSRNI5RMCIVP4WDJJBW4DSEOEFNANCNFSM4Q4MH44A&data=02%7C01%7CJodom.Konuko%40microsoft.com%7Ce97d5992c864434cb68508d85267c33b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637349952892766825&sdata=OD7W%2Fd1k67Fk9MqU%2FOX3mlbY3MbI3GNCxlCnMl6hnPU%3D&reserved=0.

[okjodom]

You can assign this to me. Quick fix coming soon

[okjodom]

Apparently, create new has always been broken, but previously was showing a giant error and crashing app. It makes sense in dev mode since we are trying create new without graph connection, and I think the fix here is better error handling. To validate this works in prod though, a test neo4j driver that works simulating graph connection should suffice. That or requiring dev environment to connect to local neo4j installment.

Ref: https://github.com/stellasia/neomap/pull/75#discussion_r479711361

[AVSuni]

Hi guys, thanks for the effort to create the app. What is the latest status of this bug? I am trying to connect to a remote database and I run into

reloads the page without actually updating the map. On top of that, the available node labels and properties are not shown anymore

[okjodom]

@AVSuni, sorry about that. Pushing out a fix asap.

[okjodom]

Ideally the fix would go after currently open PR #79 . cc @stellasia

[stellasia]

Not sure it is related, since the bug should only be on master branch (I mean, with the root cause we have in mind @jodom ). @AVSuni , which version/tag are you using?

[AVSuni]

Thanks, I am using the stock version 0.5.0 from registry.npmjs.org. I have tried it (0.5.0) with Neo4J Desktop 1.3.8 and 1.3.4

` _rev	"1-cc4cfed9c2d9d24fbdaa90f02fb509cb"
name	"neomap"
dist-tags
latest	"0.5.1"
versions
0.5.0
name	"neomap"
version	"0.5.0"
author
name	"Estelle Scifo"
private	false
neo4jDesktop
apiVersion	"^1.2.4"
licenseRequired	false
dependencies
bootstrap	"^4.3.0"
downloadjs	"^1.4.7"
graph-app-kit	"^1.0.4"
leaflet	"^1.5.1"
leaflet.heat	"^0.2.0"
leaflet.markercluster	"^1.4.1"
neo4j-driver	"^4.0.2"
react	"^16.3.2"
react-bootstrap	"^1.0.0-beta.14"
react-color	"^2.18.0"
react-confirm-alert	"^2.4.1"
react-dom	"^16.3.2"
react-redux	"^7.2.0"
react-scripts	"^3.3.1"
react-select	"^3.0.4"
redux	"^4.0.5"

`

[stellasia]

@jodom , I managed to solve the problem on the master branch by removing the type="submit" on the layer's buttons. If you have some time to check and confirm this.

[stellasia]

This issue should be solved thanks to #88, new version will be released as soon as the master branch is stable again.